Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jf_test_01 for NVHPC by removing unnecessary function in function #549

Closed
wants to merge 2 commits into from

Conversation

EmilyBourne
Copy link
Contributor

@EmilyBourne EmilyBourne commented Feb 5, 2024

As discussed in #531. Fix jf_test_01 with the NVHPC compiler by eliminating the function within a function.

@EmilyBourne EmilyBourne changed the title Fix test_01 for NVHPC by removing unnecessary function in function Fix jf_test_01 for NVHPC by removing unnecessary function in function Feb 5, 2024
@jacobwilliams
Copy link
Owner

note: jf_test_16 test is failing for some reason... looking into it.... see develop branch: https://github.com/jacobwilliams/json-fortran/actions/runs/9148368679/job/25150818128?pr=555

@jacobwilliams
Copy link
Owner

ah, I think I see why. in this new formulation without the internal function, there's no way for that internal call to json%traverse to update the finished argument. So I guess there was a reason it was like that. I'd need to think about how to make it work... it could be done using an internal wrapper function to call the traverse_callback, but then we are back to where we started with a function within a function?

@EmilyBourne
Copy link
Contributor Author

ah, I think I see why. in this new formulation without the internal function, there's no way for that internal call to json%traverse to update the finished argument. So I guess there was a reason it was like that. I'd need to think about how to make it work... it could be done using an internal wrapper function to call the traverse_callback, but then we are back to where we started with a function within a function?

Ah I see what you mean. I agree we would either need a second function or a function in a function again. I have checked the status of the nvfortran compiler (24.3) and updated #531 . It seems that this test is no longer failing so maybe this PR can be closed anyway.

@jacobwilliams jacobwilliams mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants