Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: setup build configuration #433

Closed
wants to merge 1 commit into from
Closed

refactor: setup build configuration #433

wants to merge 1 commit into from

Conversation

ValMystletainn
Copy link

simplify the package confiugration file mentioned in PR #431 and issue #429
as mentioned in this issue. I have refactored the files, save only pyproject.toml and requirements.txt. Besides, I added the dynamic version in pyproject.toml, note by the building tool setuptools-git-versioning

since I have no permission to tag the master branch or make a release. You may tag the version for those important commits by yourself and then build it and release it. The setup git versioning just give 0.0.1 right now since there is no tag on the repo now.

By the way, since you don't merge the PR #431 in github, but I noticed that the 1.4.8 are now on in pypi. so I don't you whether I should continue working on my last commit or checkout from master to a new branch. I finally chose the latter one. So I think I should mention that, the MANIFEST.in is no longer in need if this PR is accepted

reference:
setuptools-git-versioning: https://setuptools-git-versioning.readthedocs.io
setuptools-git-versioning by git tag: https://setuptools-git-versioning.readthedocs.io/en/stable/schemas/tag/tag_release.html

@jacobgil
Copy link
Owner

Thanks a lot for this, it's a great contribution.
Before merging I want to test it a bit too, and might come back with questions/comments. For example, I want to see what this does with the notebooks folder.
Thank you!

@ValMystletainn
Copy link
Author

Thanks a lot for this, it's a great contribution. Before merging I want to test it a bit too, and might come back with questions/comments. For example, I want to see what this does with the notebooks folder. Thank you!

ok, it's my pleasure

@ValMystletainn ValMystletainn closed this by deleting the head repository Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants