-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add badelf and warren_lab apps 🎅 #547
Conversation
Added warrenapp to simmate and fixed imports. Also removed several not very useful nested workflows.
@jacksund I think I've made adjustments based off of each of your comments. I'm working on running the test suite now (#546 (comment)) and prepping for a new release. |
thanks for going through! Normally release prep should be its own PR -- also I'm the only one that has permissions to do some of the steps listed in that guide. I'm going to go through and make some edits on your code, then merge. I may move the release changes into a separate PR too |
fyi -- the prebuilt database will be broken for this PR because you deleted the migration files in one of your recent commits 0dd5ce0. These migrations need to be re-added and then you can use I learned earlier this year that we were incorrectly deleting/restarting migrations every time we had an update. We actually want to commit migrations to the repo! That way users can easily update their database between simmate versions / new releases. Other django apps do this too (here is allauth's migrations as an example here) |
Oops good to know. I'll add them back and commit them. |
Add back migrations
also not sure if you saw this: https://github.com/SWeav02/simmate/pull/20. Once merged, it will update this PR too |
I'm looking through it now 😆 |
clean up all app docs
@SWeav02 take a look through & merge https://github.com/SWeav02/simmate/pull/22 when you get the chance. I removed |
prep apps for initial merge
fix workflow util unit test
remove workflow types from test
only the linux ci is failing but its unrelated to this PR. The error is because a new pydantic version was released 6 hrs ago https://anaconda.org/conda-forge/pydantic. merging and will address the pydantic issue elsewhere |
Add a badelf app with a class oriented version of the badelf algorithm. Also add a warrenapp app which contains many convenience workflows for the warren lab.