Actually handle more than 4 result columns from IDENTIFY_SYSTEM #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR appears to resolve an issue we encountered recently, also using AlloyDB. The added column is "authtoken", and is not relevant to our workflow. This field-inclusion does not appear to be documented anywhere, either in AlloyDB docs or the google/alloydbomni image. The google/alloydbomni image appears to not make this same field-inclusion, which further confirms that this is not meaningful for replication consumers. |
|
I added Issue #75 to explain the impact of the issue which this PR resolves. |
scott-rc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry, this is a follow up to #73 -- I accidentally made
ParseCreateReplicationSlothandle more than 4 result columns rather thanParseIdentifySystem🤦This PR reverts my original commit in #73 and makes the actual change I meant to make.