Simplifying generated XPath when there is only a single sibiling #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for a HTML document it will start /html[1]/body[1] even though conventionally we only expect one html and one body element. Adding a check to omit the sibiling specifier if there is only a single sibling, and updating the unit tests accordingly
|
Thanks for the pull request and feedback. I cannot merge this pull request in its current state, as it will break existing functionality. But I agree that such a distinction might be useful to some users. I will implement a more reusable #122 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lukas,
Thanks for this great library.
I am using jOOX with HTML having heard about it here
http://stackoverflow.com/questions/4746299/generate-get-xpath-from-xml-node-java
When jOOX generates an XPath, it will add [1] even if there is only a single element. For example for a HTML document the generated XPath will start /html[1]/body[1] even though we only expect one html and one body element. This is mainly a problem for human readability.
I have modified the code to add a check to omit the sibling specifier if there is only a single sibling, and I have updated the unit tests accordingly.
What do you think?