Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(downloader): allow download of grouped message. #795

Merged
merged 8 commits into from
Nov 17, 2024

Conversation

F-TD5X
Copy link
Contributor

@F-TD5X F-TD5X commented Nov 9, 2024

allows to download grouped message.

@F-TD5X F-TD5X requested a review from iyear as a code owner November 9, 2024 06:41
@iyear iyear force-pushed the master branch 3 times, most recently from 43e6adc to 55b1306 Compare November 9, 2024 12:17
@iyear
Copy link
Owner

iyear commented Nov 15, 2024

@F-TD5X Thanks for your contribution! I made some modifications to the original PR:

  1. Added the --group flag to enable this feature. To maintain backward compatibility, the default value is false.
  2. Added the corresponding documentation.

Please review my modifications.

@iyear iyear linked an issue Nov 15, 2024 that may be closed by this pull request
@iyear
Copy link
Owner

iyear commented Nov 17, 2024

The current implementation causes the inability to resume file downloads for the same group of messages when "resuming downloads"

@iyear
Copy link
Owner

iyear commented Nov 17, 2024

To include this feature in version v0.18.0, I will merge it first. If you have any other opinions, feel free to comment.

@iyear iyear merged commit bdd84cc into iyear:master Nov 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] add download grouped messages support
2 participants