feat: chat ls logging improvements and infinite looping issue fix#1117
Open
EzekialSA wants to merge 1 commit intoiyear:masterfrom
Open
feat: chat ls logging improvements and infinite looping issue fix#1117EzekialSA wants to merge 1 commit intoiyear:masterfrom
EzekialSA wants to merge 1 commit intoiyear:masterfrom
Conversation
…rror handling - Implement manual pagination with proper offset handling to avoid API issues - Add global entity accumulation across all batches for complete peer resolution - Implement deduplication using seen dialogs map to prevent duplicate entries - Add extensive logging for debugging pagination and dialog processing - Improve error handling for invalid peers (deleted channels, banned users) - Simplify table output format (remove runewidth truncation complexity) - Add detailed processing summary with counts for blocked, nil, and skipped dialogs - Fix infinite loop issues with duplicate dialog detection in pagination - Handle edge cases: empty messages, DialogFolder types, missing access hashes - Pass logger to printTable for better observability - Return dialogs with empty topics array instead of nil on topic fetch errors This is a more comprehensive fix than upstream's basic index check, providing production-ready pagination handling and better user experience.
|
@EzekialSA hello join https://t.me/happylibrary >>> View discussion >>> join. logs It should start downloading from the latest to the earliest ID.
It should start downloading from the latest to the earliest ID.
|
|
EzekialSA Sorry, this isn’t your PR’s fault; it’s a bug in TDL itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had this ready to go, someone pushed a change and I had no idea that my PR was merged already. I went ahead and closed it and rebased my fork to match and am properly doing branches for features. I've been using this in my lab for a couple weeks with zero issues.
Replace query.GetDialogs() iterator with manual pagination using MessagesGetDialogs API
to fix multiple critical issues with dialog listing functionality.
Problems fixed:
Index out of range panic when accessing empty Messages array in fetchTopics
Incomplete dialog fetching
Infinite loop causing flood waits due to incorrect offset calculation
Entity population failures preventing proper dialog processing
Hard failures when encountering deleted/inaccessible channels
Additional improvements: