fix: tf backend get_item and add set_item #28823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sam-Armstrong
commented
Sep 15, 2024
Comment on lines
-186
to
-187
| except IndexError: | ||
| raise |
There was a problem hiding this comment.
need to remove this so the backend implementation can be called, which handles an IndexError when the query is a multi-dimensional tensor
|
@hmahmood24 does this look ok? |
hmahmood24
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
@Sam-Armstrong Looks good! get_item is a critical function used everywhere so might be good to keep this on a separate branch and rerunning the integration tests from this branch to see this change doesn't break any other case and then merge into main. What do you think?
Sam-Armstrong
changed the title
hmahmood24
force-pushed
the
get-item
branch
from
d5e3461
to
2ee38cf
Compare
Co-authored-by: ivy-dev-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ivy.get_item with a tensorflow backend in the case that the query passed is a multi-dimensional tensor.