Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paddle frontend cholesky_solve added #21291

Merged
merged 9 commits into from
Aug 17, 2023
Merged

paddle frontend cholesky_solve added #21291

merged 9 commits into from
Aug 17, 2023

Conversation

dhanush-2501
Copy link
Contributor

Close #21182

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 4, 2023
@dhanush-2501
Copy link
Contributor Author

Hi @AnnaTz, can you pls check on this?

AnnaTz
AnnaTz approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@AnnaTz AnnaTz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AnnaTz AnnaTz merged commit 461d7cc into ivy-llc:main Aug 17, 2023
115 of 133 checks passed
@dhanush-2501 dhanush-2501 deleted the paddle_cholesky_solve branch August 17, 2023 16:27
sushmanthreddy pushed a commit to sushmanthreddy/ivy that referenced this pull request Aug 17, 2023
@dhanush-2501 @sushmanthreddy
paddle frontend cholesky_solve added (ivy-llc#21291)
70685b5 
Co-authored-by: @AnnaTz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaTz AnnaTz AnnaTz approved these changes

Assignees

@AnnaTz AnnaTz

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cholesky_solve
3 participants
@dhanush-2501 @AnnaTz @ivy-leaves