Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dpSwitch implementation by thalerjonathan (issue #40) #316

Conversation

geroldmeisinger
Copy link
Contributor

@ivanperez-keera
Copy link
Owner

Is this tested? Does it behave the same way as Yampa's dpSwitch?

The same comments as in #324 (comment) would apply.

@ivanperez-keera
Copy link
Owner

Plus squashing commits as appropriate.

@ivanperez-keera
Copy link
Owner

Also, since this doesn't really close issue #40, it would create a commit tree in which it is unclear when issues are finished (all issues reference numbers, but a merge doesn't mean that the problem described is completely solved).

It's best to either create a separate issue for dpSwitch, or wait to add more definitions from Yampa and include it there.

@geroldmeisinger
Copy link
Contributor Author

not tested. my intention was to cast Jonathan's contribution into code and make it available "somewhere" and go on from there (with tests and fixes). It doesn't belong in develop, but I cannot suggest different branches with PRs.

Parallel composition and switching over collections with routing
Implementation by thalerjonathan (see issue ivanperez-keera#40).

copied code doc from Yampa
@ivanperez-keera
Copy link
Owner

This has now been made part of #426, which should be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants