Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add search button to search bar #4706

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thansk
Copy link

@thansk thansk commented May 19, 2024

No description provided.

@thansk thansk requested a review from a team as a code owner May 19, 2024 11:48
@thansk thansk requested review from syeopite and removed request for a team May 19, 2024 11:48
@unixfox
Copy link
Member

unixfox commented May 19, 2024

Why? There is no description.

@ChunkyProgrammer
Copy link
Contributor

Related: #4098

@thansk
Copy link
Author

thansk commented May 19, 2024

Because I find that sometimes I enter something into the box and later want to submit it without my keyboard around.

I think it's generally a good idea for accessibility to make invidious usable without a keyboard.

@unixfox
Copy link
Member

unixfox commented May 19, 2024

Ha ok you just added a button on the search bar.

The title is very confusing.

To be fair I quite like the way it is without any search button.

I think I good compromise would be to just have the search icon. Not the full text "Search". Like on youtube.com

@thansk
Copy link
Author

thansk commented May 20, 2024

I added an icon instead and used the aria-label for it with the translation like @ChunkyProgrammer suggested. Icon is using the currentColor so it works on dark and light theme. It's MIT licensed from heroicons.

@unixfox
Copy link
Member

unixfox commented May 20, 2024

Please use the built-in icons instead: https://github.com/iv-org/invidious/blob/master/assets/fonts/ionicons.svg

@thansk
Copy link
Author

thansk commented May 20, 2024

Yeah, that makes sense, it should be good now.

@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label May 20, 2024
@SamantazFox SamantazFox changed the title feat: allow submitting search with mouse UI: Add search button to search bar May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants