Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zh/modules search #61

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Zh/modules search #61

wants to merge 7 commits into from

Conversation

zkhussain
Copy link
Contributor

@zkhussain zkhussain commented Jan 4, 2022

The frontend PR for this (ius-csg/cslabs-webapp#69).

I've some duplicated code, I was thinking to create a separate search method and call that, should I create a class for that in Util or add it in Module.cs?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Cliftonz
Cliftonz previously approved these changes Jan 4, 2022
Copy link
Member

@Cliftonz Cliftonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zkhussain zkhussain changed the base branch from dev to main January 11, 2022 01:42
@zkhussain zkhussain changed the base branch from main to dev January 11, 2022 01:42
@zkhussain zkhussain dismissed Cliftonz’s stale review January 11, 2022 01:42

The base branch was changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants