modrinth: version-from-modrinth-projects improved logging and error handling - #860
Merged
Merged
Conversation
…#processgGameVersions
Supports .distinct() in VersionFromModrinthProjectsCommand
This was
linked to
issues
Sep 5, 2026
itzg
reviewed
Sep 5, 2026
itzg
left a comment
itzg
left a comment
Owner
There was a problem hiding this comment.
Nice and slim! I'm good to merge, but just curious first on the GenericException
itzg
changed the title
itzg
approved these changes
Sep 5, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revision of #854, added logging and error handling supporting #630, #676
Version Blame
When running
version-from-modrinth-projectsfails, and--debugis passed, logs are printed, noting which modrinth projects are blocking each Minecraft version../gradlew run --args="--debug version-from-modrinth-projects --loader=paper --projects=paper:viaversion,paper:viabackwards,paper:griefprevention,paper:discordsrv,paper:pl3xmap"Empty and Null project Exceptions
When an empty projects list is passed, or no projects are parsed,
InvalidParameterExceptionis thrown./gradlew run --args="version-from-modrinth-projects --projects= "./gradlew run --args="version-from-modrinth-projects"Added tests asserting errors thrown for both cases.
ProjectRef parse tightening
Tightens initial ref passthrough; filtering whitespace and duplicate entries.