Add a resizeObserver to table cells to set cell height #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using slotted content in a table cell, it currently is not possible to set the content to be 100% of the cell. This is because using a slot takes the content our of the normal flow and it doesn't know what height it should use when set to 100%. By adding a resizeObserver to see the height of the cell and set that height manually, the descendant content can set height:100% and it will work as expected. While each cell will be set to it's own height, the nature of table rows means that all cells in a row will display as the height of the tallest cell, regardless of what height they have manually set.
brentswisher
requested review from
sirrah-tam,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
|
12 tasks
daneah
approved these changes
Jan 29, 2025
|
🤔 Something it making it grow very slightly for each row - https://www.chromatic.com/test?appId=60919c26122bd50039b34644&id=679aa5fdfaecae4253b8e997 |
satya-achanta-venkata
approved these changes
Jan 30, 2025
|
brentswisher
added a commit
that referenced
this pull request
Jan 30, 2025
* feat(table): allow more complex data in table * chore(table): add changeset * feat(table): update table rowData tests * feat(table): add tests for content added via slot * feat(table): add test coverage for new elements * fix: revert unintended update to changelog * Add a resizeObserver to table cells to set cell height (#862) * fix(table): add resizeObserver to set cell height When using slotted content in a table cell, it currently is not possible to set the content to be 100% of the cell. This is because using a slot takes the content our of the normal flow and it doesn't know what height it should use when set to 100%. By adding a resizeObserver to see the height of the cell and set that height manually, the descendant content can set height:100% and it will work as expected. While each cell will be set to it's own height, the nature of table rows means that all cells in a row will display as the height of the tallest cell, regardless of what height they have manually set. * fix(table): account for border when calculating height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
It was impossible to set table cell content to fill the height of a cell. This allow that to happen.
How does this change work?
When using slotted content in a table cell, it currently is not possible to set the content to be 100% of the cell. This is because using a slot takes the content our of the normal flow and it doesn't know what height it should use when set to 100%. By adding a resizeObserver to see the height of the cell and set that height manually, the descendant content can set height:100% and it will work as expected.
While each cell will be set to it's own height, the nature of table rows means that all cells in a row will display as the height of the tallest cell, regardless of what height they have manually set.
Additional context
This is stacked on top of #840 for easier reviewing and will be merged into it before merging both change to develop at once