Radio, Checkbox: Fix group label #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove concatenation for label reference as well as the aria-labelledby attribute so thelegend element is used to calculate accName for group. Added the aria-describedby attribute with the ID ref message to look for the associated hint/description text.
sirrah-tam
requested review from
eslawski,
jialin-he and
mtorres3
and removed request for
a team
🦋 Changeset detectedLatest commit: d4146e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sirrah-tam
changed the title
packages/pharos/src/components/checkbox-group/pharos-checkbox-group.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Brent Swisher <[email protected]>
daneah
changed the title
daneah
reviewed
Nov 28, 2023
packages/pharos/src/components/checkbox-group/pharos-checkbox-group.ts
Outdated
Show resolved
Hide resolved
daneah
approved these changes
Nov 28, 2023
brentswisher
requested changes
Nov 28, 2023
daneah
reviewed
Nov 30, 2023
packages/pharos/src/components/checkbox-group/pharos-checkbox-group.test.ts
Outdated
Show resolved
Hide resolved
packages/pharos/src/components/radio-group/pharos-radio-group.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dane Hillard <[email protected]>
Co-authored-by: Dane Hillard <[email protected]>
brentswisher
approved these changes
Nov 30, 2023
sirrah-tam
added a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
* docs: add @sirrah-tam as a contributor * fix: update radio/checkbox labeling Remove concatenation for label reference as well as the aria-labelledby attribute so thelegend element is used to calculate accName for group. Added the aria-describedby attribute with the ID ref message to look for the associated hint/description text. * chore: add changeset * fix: use messageID value for aria-describedby ref Co-authored-by: Brent Swisher <[email protected]> * fix(radio/checkbox): add ifDefined directive for aria-describedby * test(radio/checkbox group): add tests for accDesc * fix: use template literal for groupID expression Co-authored-by: Dane Hillard <[email protected]> * fix: use template literal for groupID expression Co-authored-by: Dane Hillard <[email protected]> --------- Co-authored-by: Brent Swisher <[email protected]> Co-authored-by: Dane Hillard <[email protected]>
daneah
added a commit
that referenced
this pull request
Dec 19, 2023
* develop: A11y revamp: Pharos buttons (non-breaking change) (#628) Radio, Checkbox: Fix group label (#652) Add elevation tokens and documentation (#643) fix(sidenav-link): external link opens in new tab (#645) Upgrade to TypeScript 5 (#644) feat(cli): add newly created components created using pharos-cli to initComponents files (#630) chore: version packages (#640) Coach Mark: Fix react component positioning (#638) Coach Mark: Documentation fixes (#639) chore(deps): bump @babel/traverse from 7.20.0 to 7.23.2 (#637) chore: version packages (#636) Icon: Add Panorama icon (#631) chore: version packages (#629) Loading spinner: add small and on background variant (#627) chore: version packages (#626) Sheet: allow expansion with attribute (#625) fix(button): remove fill on subtle disabled button on background (#618) chore(deps-dev): bump postcss from 8.4.25 to 8.4.31 (#624) chore: version packages (#623) Sheet: Add more close options and transition timing function (#620)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Fixes #651
This change ensures the associated hint text or error messages for radio & checkbox groups are calculated as the group's accessible description (accDesc) rather than as part of the accessible name (accName).
How does this change work?
The concatenation for the label as well as the
aria-labelledbyattribute is removed to allow thelegendelement to calculate the group's accName. Adding thearia-describedbyattribute with its value referencing the IDmessagewill ensure that any hint text or error message that is supplied gets added as the groups accDesc.