-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use base URL of GitLab for the /uploads
URLs
#1482
Conversation
@jancrichter, if you can test it with older GitLab versions and confirm it works as well, we can release this fix. Note It's a bit hacky, as it doesn't output full URLs unlike the assets.cml.dev uploads, but... 🤷🏼 |
Hi, thanks for looking into it. Although, I am confused due to the PR being closed and the branch deleted, is it still an option to release this? Myself, I cannot test on older Gitlab versions unfortunately, but the shortened link is what Gitlab has been using for native use uploads at least since Gitlab 15 from looking at the API. |
@jancrichter, yes, I just closed it because I wasn't willing to merge this change without your confirmation, but if it runs on GitLab 15+, it feels like a good enhancement to me. (Now it's merged and released, for the record) |
Could close #1478; not sure about compatibility with old GitLab versions, though.