Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system_group option #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add system_group option #297

wants to merge 1 commit into from

Conversation

takumin
Copy link
Contributor

@takumin takumin commented Jul 31, 2019

-r, --system option of groupadd(8)

@takumin
Add system_group option
5552ec7 
-r, --system option of groupadd(8)
@takumin
Copy link
Contributor Author

takumin commented Jul 31, 2019

Merged Specinfra: mizzy/specinfra@30e1c21

@sue445 sue445 requested review from sue445 and unasuke July 31, 2019 11:23
unasuke
unasuke approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Could you add any test case if possible?

@takumin
Copy link
Contributor Author

takumin commented Jul 31, 2019

thank you for your comment.
I'm sorry I forgot to add a test case.

I think Serverspec needs a new resource type.
Add a test case when a new resource type is added.

@takumin
Copy link
Contributor Author

takumin commented Jul 31, 2019

I created the following pull request:

mizzy/specinfra#694

Besides this, I would like to add test cases after the necessary corrections are merged.

It takes a long time, I am sorry.

@unasuke
Copy link
Member

unasuke commented Aug 1, 2019

Great!!

@unasuke
Copy link
Member

unasuke commented Jun 4, 2020

Sorry, I forgot about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unasuke unasuke unasuke approved these changes

@sue445 sue445 Awaiting requested review from sue445

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takumin @unasuke