feat: contractors and contacts validation

.devcontainer/devcontainer.json

@@ -0,0 +1,24 @@
+{
+	"name": "PublicCodeGoParser",
+	"runArgs": [
+		"--name=PublicCodeGoParser"
+	],
+	"image": "mcr.microsoft.com/devcontainers/go:1-1.23-bookworm",
+	"features": {
+		"ghcr.io/devcontainers/features/docker-in-docker:2": {
+			"moby": true,
+			"azureDnsAutoDetection": true,
+			"installDockerBuildx": true,
+			"installDockerComposeSwitch": true,
+			"version": "latest",
+			"dockerDashComposeVersion": "v2"
+		}
+	},
+	"customizations": {
+		"vscode": {
+			"extensions": [
+				"redhat.vscode-yaml"
+			]
+		}
+	}
+}

parser.go

@@ -193,6 +193,9 @@ func (p *Parser) ParseStream(in io.Reader) (PublicCode, error) {
 			"iso3166_1_alpha2_lowercase": "must be a valid lowercase ISO 3166-1 alpha-2 two-letter country code",
 			"bcp47_language_tag":         "must be a valid BCP 47 language",
 			"bcp47_keys":                 "must use a valid BCP 47 language",
+			"required_if":                "must be present if",
+			"excluded_unless":            "must not be present unless",
+			"excluded_unless=Type community|excluded_unless=Type internal": "must not be present unless Type is community or internal",
 		}
 		for _, err := range err.(validator.ValidationErrors) {
 			var sb strings.Builder

parser_test.go

@@ -458,16 +458,31 @@ func TestInvalidTestcasesV0(t *testing.T) {
 		// maintenance
 		// maintenance.*
 		"maintenance_type_missing.yml": ValidationResults{
-			ValidationError{"maintenance.type", "required", 47, 3},
+			ValidationError{"maintenance.type", "required", 43, 13},
 		},
 		"maintenance_type_invalid.yml": ValidationResults{
 			ValidationError{"maintenance.type", "must be one of the following: internal contract community none", 45, 3},
 		},
+		"maintenance_contractors_excluded_if_type_community.yml": ValidationResults{
+			ValidationError{"maintenance.contractors", "must not be present unless Type contract", 47, 3},
+		},
+		"maintenance_contractors_excluded_if_type_internal.yml": ValidationResults{
+			ValidationError{"maintenance.contractors", "must not be present unless Type contract", 47, 3},
+		},
+		"maintenance_contractors_excluded_if_type_none.yml": ValidationResults{
+			ValidationError{"maintenance.contractors", "must not be present unless Type contract", 47, 3},
+		},
 		"maintenance_contacts_missing_with_type_community.yml": ValidationResults{
-			ValidationError{"maintenance.contacts", "required_if Type community", 44, 3},
+			ValidationError{"maintenance.contacts", "must be present if Type community", 44, 3},
 		},
 		"maintenance_contacts_missing_with_type_internal.yml": ValidationResults{
-			ValidationError{"maintenance.contacts", "required_if Type internal", 44, 3},
+			ValidationError{"maintenance.contacts", "must be present if Type internal", 44, 3},
+		},
+		"maintenance_contacts_excluded_if_type_contract.yml": ValidationResults{
+			ValidationError{"maintenance.contacts", "must not be present unless Type is community or internal Type internal", 51, 3},
+		},
+		"maintenance_contacts_excluded_if_type_none.yml": ValidationResults{
+			ValidationError{"maintenance.contacts", "must not be present unless Type is community or internal Type internal", 46, 3},
 		},
 		"maintenance_contacts_name_missing.yml": ValidationResults{
 			ValidationError{"maintenance.contacts[0].name", "required", 0, 0},
@@ -476,11 +491,11 @@ func TestInvalidTestcasesV0(t *testing.T) {
 			ValidationError{"maintenance.contacts[0].email", "must be a valid email", 0, 0},
 		},
 		"maintenance_contractors_missing_with_type_contract.yml": ValidationResults{
-			ValidationError{"maintenance.contractors", "required_if Type contract", 44, 3},
+			ValidationError{"maintenance.contractors", "must be present if Type contract", 44, 3},
 		},
 		"maintenance_contractors_invalid_type.yml": ValidationResults{
 			ValidationError{"maintenance.contractors", "wrong type for this field", 47, 1},
-			ValidationError{"maintenance.contractors", "required_if Type contract", 47, 3},
+			ValidationError{"maintenance.contractors", "must be present if Type contract", 47, 3},
 		},
 		"maintenance_contractors_name_missing.yml": ValidationResults{
 			ValidationError{"maintenance.contractors[0].name", "required", 0, 0},
@@ -736,3 +751,22 @@ func TestToURL(t *testing.T) {
 		}
 	}
 }
+
+func TestInvalidContractorsMustBeIgnored(t *testing.T) {
+	expected := error(
+		ValidationResults{
+			ValidationError{"maintenance.contractors", "must not be present unless Type contract", 47, 3},
+		},
+	)
+
+	parser, errParser := NewParser(ParserConfig{DisableNetwork: true})
+	if errParser != nil {
+		t.Errorf("Can't create Parser: %v", errParser)
+	}
+	var file = "testdata/v0/invalid/maintenance_contractors_excluded_if_type_community.yml"
+	_, err := parser.Parse(file)
+
+	if err != nil && expected != nil && err.Error() != expected.Error() {
+		t.Errorf("Expected contractors excluded_if error")
+	}
+}

testdata/v0/invalid/landingURL_invalid.yml

@@ -79,20 +79,6 @@ maintenance:
       website: "https://developers.italia.it"
       until: "2019-01-01"
 
-  contacts:
-    - name: Francesco Rossi
-      email: "[email protected]"
-      affiliation: Comune di Reggio Emilia
-      phone: +39 231 13215112
-    - name: Dario Bianchi
-      email: "[email protected]"
-      affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
-    - name: Giancarlo Verdi
-      email: "[email protected]"
-      affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
-
 localisation:
   localisationReady: true
   availableLanguages:

testdata/v0/invalid/landingURL_wrong_type.yml

@@ -75,20 +75,6 @@ maintenance:
       website: "https://developers.italia.it"
       until: "2019-01-01"
 
-  contacts:
-    - name: Francesco Rossi
-      email: "[email protected]"
-      affiliation: Comune di Reggio Emilia
-      phone: +39 231 13215112
-    - name: Dario Bianchi
-      email: "[email protected]"
-      affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
-    - name: Giancarlo Verdi
-      email: "[email protected]"
-      affiliation: Fornitore Privato S.P.A.
-      phone: +39 16 24231322
-
 localisation:
   localisationReady: true
   availableLanguages:

testdata/v0/invalid/maintenance_contacts_excluded_if_type_contract.yml

@@ -0,0 +1,57 @@
+publiccodeYmlVersion: "0.4"
+
+name: Medusa
+url: "https://github.com/italia/developers.italia.it.git"
+softwareVersion: "dev"
+releaseDate: "2017-04-15"
+
+platforms:
+  - web
+
+categories:
+  - cloud-management
+
+developmentStatus: development
+
+softwareType: "standalone/other"
+
+description:
+  en:
+    localisedName: Medusa
+    shortDescription: >
+          A rather short description which
+          is probably useless
+    longDescription: >
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 158 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 316 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 474 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 632 characters.
+    features:
+       - Just one feature
+
+legal:
+  license: AGPL-3.0-or-later
+
+maintenance:
+  type: "contract"
+
+  # Should NOT validate: invalid payload
+  contractors:
+    - name: "Fornitore Privato SPA"
+      website: "https://developers.italia.it"
+      until: "2019-01-01"
+  contacts:
+    - name: Francesco Rossi
+
+localisation:
+  localisationReady: true
+  availableLanguages:
+    - en

testdata/v0/invalid/maintenance_contacts_excluded_if_type_none.yml

@@ -0,0 +1,52 @@
+publiccodeYmlVersion: "0.4"
+
+name: Medusa
+url: "https://github.com/italia/developers.italia.it.git"
+softwareVersion: "dev"
+releaseDate: "2017-04-15"
+
+platforms:
+  - web
+
+categories:
+  - cloud-management
+
+developmentStatus: development
+
+softwareType: "standalone/other"
+
+description:
+  en:
+    localisedName: Medusa
+    shortDescription: >
+          A rather short description which
+          is probably useless
+    longDescription: >
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 158 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 316 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 474 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 632 characters.
+    features:
+       - Just one feature
+
+legal:
+  license: AGPL-3.0-or-later
+
+maintenance:
+  type: "none"
+
+  contacts:
+    - name: Francesco Rossi
+
+localisation:
+  localisationReady: true
+  availableLanguages:
+    - en

testdata/v0/invalid/maintenance_contractors_excluded_if_type_community.yml

@@ -0,0 +1,57 @@
+publiccodeYmlVersion: "0.4"
+
+name: Medusa
+url: "https://github.com/italia/developers.italia.it.git"
+softwareVersion: "dev"
+releaseDate: "2017-04-15"
+
+platforms:
+  - web
+
+categories:
+  - cloud-management
+
+developmentStatus: development
+
+softwareType: "standalone/other"
+
+description:
+  en:
+    localisedName: Medusa
+    shortDescription: >
+          A rather short description which
+          is probably useless
+    longDescription: >
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 158 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 316 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 474 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 632 characters.
+    features:
+       - Just one feature
+
+legal:
+  license: AGPL-3.0-or-later
+
+maintenance:
+  type: "community"
+
+  # Should NOT validate: invalid payload
+  contractors:
+    - name: "Fornitore Privato SPA"
+      website: "https://developers.italia.it"
+      # until: "2019-01-01"
+  contacts:
+    - name: Francesco Rossi
+
+localisation:
+  localisationReady: true
+  availableLanguages:
+    - en

testdata/v0/invalid/maintenance_contractors_excluded_if_type_internal.yml

@@ -0,0 +1,57 @@
+publiccodeYmlVersion: "0.4"
+
+name: Medusa
+url: "https://github.com/italia/developers.italia.it.git"
+softwareVersion: "dev"
+releaseDate: "2017-04-15"
+
+platforms:
+  - web
+
+categories:
+  - cloud-management
+
+developmentStatus: development
+
+softwareType: "standalone/other"
+
+description:
+  en:
+    localisedName: Medusa
+    shortDescription: >
+          A rather short description which
+          is probably useless
+    longDescription: >
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 158 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 316 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 474 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 632 characters.
+    features:
+       - Just one feature
+
+legal:
+  license: AGPL-3.0-or-later
+
+maintenance:
+  type: "internal"
+
+  # Should NOT validate: invalid payload
+  contractors:
+    - name: "Fornitore Privato SPA"
+      website: "https://developers.italia.it"
+      # until: "2019-01-01"
+  contacts:
+    - name: Francesco Rossi
+
+localisation:
+  localisationReady: true
+  availableLanguages:
+    - en