-
Notifications
You must be signed in to change notification settings - Fork 118
fix: look for country code IT in publiccode data
#1592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a9a9a36 to
efb7f6f
Compare
efb7f6f to
2588f7b
Compare
Following italia/publiccode-crawler#468, the publiccode data returned by the API use the key `IT` rather than `it` for the country specific part.
2588f7b to
ed3fabc
Compare
|
@tensor5 yes, v5 is breaking. There is some retrocompatibility, but it's in the library API in the sense that Unfortunately it's tricky for the serialization because we'd serialize a Anyway, you might want to use Just note that for Italian PAs they will be URNs with this format: `"urn:x-italian-pa:CODICE_IPA" |
|
Also, take a look at italia/publiccode-editor#526 which quickly summarizes changes in v0.5. Surely the categories changes require some adapting as well, same goes for some of the other changes. |
| {% if withimages == true %} | ||
|
|
||
| {% if item.publiccode.it.riuso.codiceIPA != nil %} | ||
| {% if item.publiccode.IT.riuso.codiceIPA != nil %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can consider both cases ?
const prop = item.publiccode.['it'] || item.publiccode.['IT']; if(prop?.riuso.codiceIPA){}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. We definitely need to make it more resilient. I had to merge it quickly in order to solve our problem by today.
|
Basically, we are in the situation where we have in our database software with the same version of publiccode ("0.4"), some of which use the key |
Following italia/publiccode-crawler#468, the publiccode data returned by the API use the key
ITrather thanitfor the country specific part.Description
This PR tackles:
In particular, the ...
Checklist
Fixes
Fixes #