corrected a typo in the qualification_grading_scale fields, changing …

…its type from string to number
italia · Oct 4, 2024 · 7658de1 · 7658de1
1 parent 72b0ce6
commit 7658de1
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 25 deletions.
diff --git a/README.md b/README.md
@@ -978,7 +978,7 @@ Il [business canvas](https://docs.google.com/spreadsheets/d/1-H3R9vLX_Y3_7NxGN1I
 * [Normativa e modelli relativi al Diploma Supplement](https://www.miur.gov.it/-/nuovo-supplemento-al-diploma-con-4-allegati-relativi-alla-compilazione-e-alle-linee-guida-nazionali-per-la-digitalizzazione)
 ## Ultima Modifica 🔬
 
-12/09/2024
+04/10/2024
 
 ## Authors 🚶
 

diff --git a/doc/03_analysis/io_schema/IFS03.1-response.json b/doc/03_analysis/io_schema/IFS03.1-response.json
@@ -17,8 +17,8 @@
       "degree_class_code": "MSLM32",
       "academic_qualification_date": "2022-07-01",
       "qualification_grade_value": "110",
-      "qualification_grading_scale_minimum_grade": "66",
-      "qualification_grading_scale_maximum_grade": "110"
+      "qualification_grading_scale_minimum_grade": 66,
+      "qualification_grading_scale_maximum_grade": 110
     }
   ]
 }
diff --git a/doc/03_analysis/io_schema/IFS03.2-response.json b/doc/03_analysis/io_schema/IFS03.2-response.json
@@ -16,8 +16,8 @@
       "degree_class_name": "Ingegneria informatica",
       "academic_qualification_date": "2022-07-01",
       "qualification_grade_value": "110",
-      "qualification_grading_scale_minimum_grade": "66",
-      "qualification_grading_scale_maximum_grade": "110",
+      "qualification_grading_scale_minimum_grade": 66,
+      "qualification_grading_scale_maximum_grade": 110,
       "academic_qualification_country": "Italia"
     }
   ]

diff --git a/doc/03_analysis/io_schema/IFS03.4-response.json b/doc/03_analysis/io_schema/IFS03.4-response.json
@@ -16,8 +16,8 @@
              "degree_class_name":"Ingegneria informatica",
              "degree_course_duration_in_months":36,
              "qualification_grade_value":"100",
-             "qualification_grading_scale_minimum_grade":"66",
-             "qualification_grading_scale_maximum_grade":"110",
+             "qualification_grading_scale_minimum_grade": 66,
+             "qualification_grading_scale_maximum_grade": 110,
              "qualification_date":"2022-07-01",
              "access_to_regulated_profession":"Non applicabile",
              "administering_institute_name":"Cagliari - Università degli studi",

diff --git a/release-note.md b/release-note.md
@@ -32,6 +32,7 @@
 - [IFS04.4, IFS05.4] 03.10.2024 fixed the response of ifs04.4 and ifs05.4 
 - [IFS04.1] 03.0.2024 issue #224 Removed the nullable property from the attribute_name parameter
 - [IFS04.4, IFS05.4] 03.10.2024 issue #225 fixed the required attributes in the requests for ifs04.4 and ifs05.4.
+- [IFS03, IFS05] 04.10.2024 corrected a typo in the qualification_grading_scale fields, changing its type from string to number
 
 
 ## Version 2.0.5

diff --git a/src/IFS03-titoli.yaml b/src/IFS03-titoli.yaml
@@ -180,8 +180,8 @@ paths:
                         degree_class_name: Ingegneria informatica
                         academic_qualification_date: 2022-07-01
                         qualification_grade_value: '110'
-                        qualification_grading_scale_minimum_grade: '66'
-                        qualification_grading_scale_maximum_grade: '110'
+                        qualification_grading_scale_minimum_grade: 66
+                        qualification_grading_scale_maximum_grade: 110
                         academic_qualification_country: Italia
         '400':
           description: <b>Bad Request</b> - il server non può elaborare la richiesta del client a causa di una sintassi errata o di una richiesta non valida. <br> Esempi di cause
@@ -612,17 +612,21 @@ components:
           pattern: ^(\d+(.\d{1,2})?|\d+L|QUALIFIED|[A-Z])$
           nullable: true
         qualification_grading_scale_minimum_grade:
-          type: string
-          example: '66'
-          description: Minimum course grade / Voto minimo del corso    
-          pattern: ^(\d+(.\d{1,2})?|[A-Z])$
+          type: number
+          format: float
+          minimum: 0
+          maximum: 9999
           nullable: true
+          example: 66
+          description: Minimum course grade / Voto minimo del corso    
         qualification_grading_scale_maximum_grade:
-          type: string
-          example: '110'
-          description: Highest course grade / Voto massimo del corso
-          pattern: ^(\d+(.\d{1,2})?|[A-Z])$
+          type: number
+          format: float
+          minimum: 0
+          maximum: 9999
           nullable: true
+          example: 110
+          description: Highest course grade / Voto massimo del corso
         academic_qualification_country:
           type: string
           description: Country where it has got the academic qualification / Paese dove è stato conseguito il titolo

diff --git a/src/IFS05-rettifica-titoli.yaml b/src/IFS05-rettifica-titoli.yaml
@@ -269,8 +269,8 @@ paths:
                       degree_class_code: MSLM32
                       academic_qualification_date: 2022-07-01
                       qualification_grade_value: '110'
-                      qualification_grading_scale_minimum_grade: '66'
-                      qualification_grading_scale_maximum_grade: '110'
+                      qualification_grading_scale_minimum_grade: 66
+                      qualification_grading_scale_maximum_grade: 110
                       issues:
                         - attribute_name: degree_course_code
                           issue_description: degree course code didn't find on the controlled vocabulary
@@ -722,17 +722,21 @@ components:
           pattern: ^(\d+(.\d{1,2})?|\d+L|QUALIFIED|[A-Z])$
           nullable: true
         qualification_grading_scale_minimum_grade:
-          type: string
+          type: number
+          format: float
+          minimum: 0
+          maximum: 9999
           nullable: true
-          example: '66'
+          example: 66
           description: Minimum course grade / Voto minimo del corso
-          pattern: ^(\d+(.\d{1,2})?|[A-Z])$ 
         qualification_grading_scale_maximum_grade:
-          type: string
+          type: number
+          format: float
+          minimum: 0
+          maximum: 9999
           nullable: true
-          example: '110'          
+          example: 110        
           description: Highest course grade / Voto massimo del corso
-          pattern: ^(\d+(.\d{1,2})?|[A-Z])$ 
         issues:
           additionalProperties: false
           type: array