-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.2.0 #2383
Open
DmyMi
wants to merge
337
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release 1.2.0 #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added several unit tests to block service * removed block service unit test * added unit tests to error page component * added unit tests to message-bar component * returned first view * added unit tests to checkMatDatePicker method * added unit tests to checkInvalidText method * fixed issues with unit tests * moved mockData
* Changed application request showBlocked mode & its behaviour for All tab * Add applicationParams to parent block actions
* Changed application request showBlocked mode & its behaviour for All tab * Add applicationParams to parent block actions * Introduced showBlocked ignoring as empty string & fixed fetching applications on main applications page * - Refactored all provider workshops component - Fixed excluded id param in getting workshops request * Fix application show parameter * Fixed import path for CabinetDataComponent
…y displayed on tabs "Заклади", "Історія змін". (#2307) * first implementation of fixing the bug * removed the truncation
* Implemented tests for main page, header, footer * Fix actions in admins, directions tab and guard * Revert "Implemented tests for main page, header, footer" This reverts commit 70daf59.
* added menu for blocking and added tab in history * added base logic of blocking / unlocking parents * fixed NullInjectorError for MatDialog * Implemented main workflow of parent blocking * removed extra code lines * resolved pr commentaries
* Refactored some provider components & add condition to appear edit provider button * Refactor code for creating provider admins, fixed tab bug in provider admins list
* Implemented tests for main page, header, footer * Refactor component tests and directions-wrapper * Moved tests in reason-modal and footer to appropriate test groups, mocks and expected values * Extracted mocks from tests to main test group
* Changed hubs path * Fixed provider edit button accessibility for provider deputy/admin
… Subrole to deal with the confusion around Role/Subrole type; (#2326) - Fixed the provider deputy/admin blocking/unblocking parents issue caused by providing a wrong id for fetching new applications after blocking from the applications page (the deputy/admin endpoint requires a user id instead of provider); - Removed fetching application dispatch after blocking from a messages page.
* added base structure of parents blocking history * added tab users for techAdmin * added data to blocking parents table * added the table data filtration * fixed operation type in admins history log * reworked the history log filters * fixed unit tests error * merged the subscribers on each history * moved the code from OnChanges hook to Input setter * fixed issue of applying filters when first render
* Improved the logic of fetching an applications after block/unblock a parent * Refactored Provider DTOs corresponding to backend and also refactored related components/state/service * userId hotfix/TODO
* - Improved logic of the create-provider guard; - Refactored create and personal-cabinet guards and also, for the latest add routing for unregistered provider; - Add a menu link that leads to create-provider component so provider can complete registration after site-exploring; - Refactored message bar & add message bar type and icon enum so eliminated confusion around message bar type; also, refactored message bar data, made it more custom; - Add unclosable message on bottom of page (because on top it will overlap navigation links) that will be closed after provider will complete registration. * Fixed appearing & clearing of registration reminder message bar
* Made latitue and longitude required property in address * Hotfix for setting address marker * Little fixes & refactoring on map, create-form, create-workshop * Fixed latitude & longitude requirement in create-workshop-address
…g a provider properties (#2330) * Enable save btn on radio-btn selection change in AboutFormGroup * Enable save button on Work Days change in AboutFormGroup->Wrapper->workingHoursForm * Enable save btn on radio-btn selection change in DescriptionFormGroup * Enable save btn on key words change in DescriptionFormGroup * Enable save btn on address change in addressFormGroup * Fix availableSeats && Enable Save btn in TeacherFormArray * Enable save btn on key words change in DescriptionFormGroup (onDeleteForm) * Update create-workshop.component.ts * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-about-form.component.html * Update create-workshop-address.component.ts
… on the messages page (#2339) * added the marks on the message card * improved the parent blocking by provider * added unit tests to onBlock & onUnblock methods * fixed pr comments
… of the information is displayed in ukrainian (#2343) * added english translations to directions * fixed unit tests errors
* Removed unsubscribing from dialogRefs because of autocompleting by itself * Refactored state - removed wrapping by of() for void actions * Refactored models file names & other source code files where it used, * Rename hubs-Url.ts to hubs-url.ts * Refactored interceptors & moved snackbar to state * Add custom API error handling * Changed custom error messagebar duration from infinity to 10s
…#2353) * ministry admin's invitation functionality * region admin's invitation functionality * area admin's invitation functionality * refactored the names of methods and parameters * added the unit tests to the onSendInvitation method * moved the button Send invitation to the common menu
* Fixed sending & displaying of messages with spaces at start or end, or line-breaks * Add setting for settlement if it's single in codeficator search when creating workshop address & other improvements for that * Moved noAddressFound hint above * Add phoneNumberAlreadyTaken custom API error * Moved nested if in else to else-if * Sorted methods by access modifier and removed unused template method parameter * Fixed build error by using autocomplete for input * Fixed `isBlocked` application property changed from backend to `isBlockedByProvider`
* fetched data from endpoint and tabs removed * placeholder changed and deputy table template removed * employees tests adjusted * unit tests for employee service and component * naming updated to officialEmployee * imports sorted and comment in the model --------- Co-authored-by: Yuriy Yakymiv <[email protected]>
* added validation for unwanted email addresses * fixed validator func
* correcting dropdown menu truncation * fixed dropdown appearance in create-employee * fix comment
* Dvorak / 2717 Minor text improvements for workshop rating window
* create import/export module * install xlsx library * Added styles and translation * added guards for tech-admin * added validation to input field and compliance of headers with entered data * added filters for invalid providers * paginator * added export function * export providers completed * import-export data module beta * added all validators and tooltip * truncate pipe and paginator * modify tooltip * deleted truncate pipe ,added truncate directive and uploaded file-length filter * added interfaces * before unit-tests in import component * added new tests * added validators service * wrote test for import-validation service * added rest of unit test to import-validation service * added unit tests to import-providers.component * code improvement * send providers method added * code improvement,fixed formatting * created base component and upload employees component * provider-employee-upload code improvement * the base component and validation service logic is complete.Remove all components from the original branch * added test for base component * changed project domain * added test for validation service * code improvement * installed tailwind dependencies * shared components updated * shell components were updated * made changes that requested in comments * remove flex-layout imports in some files * remove flex-flayout dependency in yarn.lock * removed custom go-to-top button and added existing in project go-to-top button * created excel processor service,moved all associated with excel logic to this service * updated yarn.lock * modified excel-processor service;added duplicate validation in validation service * added load statuses * added employee upload service and added few feachers * updated yarn.lock * update 24/01/25 * pass tests coverage * update excel-upload.component.spec.ts * deleted all .css and css.map files * improvement of the code according to the recommendations * changed logic of isLoading,simplified provider-employee-upload * updated environments.ts storageUrl ,corrected all comments * implemented employees component * Litviniuk/validation message fix (#2735) * #2720 issue fix * fixed seats validation (#2731 issue) * delete useless property * Dvorak / 2696 Main page design (#2734) * Litviniuk/correcting dropdown menu truncation (#2732) * correcting dropdown menu truncation * fixed dropdown appearance in create-employee * fix comment * Litviniuk/fix incorrect description length (#2738) * fixed #2714 issue * fixed icon placement (#2715 issue) * Dvorak / 2717 Minor text improvements for workshop rating window (#2737) * Dvorak / 2717 Minor text improvements for workshop rating window * corrected all coments --------- Co-authored-by: darynkka <[email protected]> Co-authored-by: Dariia <[email protected]> Co-authored-by: AkunaPatlata <[email protected]>
* Created new form for contacts * Added checkbox for "Use address as primary" Refactored map component to display multiple maps on the same page Migrated create-workshop-address component from flexLayout to tailwind * Fixed not displaying map on search workshop page * Refactored workshop model to contain multiple phone numbers, emails and social networks Removed unnecessary comments * test coverage fix * Test coverage fix and removal of unnecessary comments and lines * Fixes according to comments * Fixes according to pull request comments * test fix * removed comments moved OnIsDefaultChange method above private methods * Changed socialTypesKeys get method to public socialTypesKeys = Object.keys(this.socialTypes); Refactored duplicate code in addPhoneField, addEmailField and addSocialField methods Added url validation for social networks
* added scroll to top on page change for provider-my workshops * tests
* rebase * page support for result route * page support for result route and filters change * styles fixes for card * changed ability to clear price field without autofill, added validation hint and fixed validation for payRate * payRate validation fix, teachers requred, styles fix * size support and bug fixes for query pagination * page, size query param refactor * handling non existing page and size * more test cases for validator * tests fix * tests for create description component and workshop cards list * reliability fix * requested changes * fixed image loading
#2741) * Highlight payment type dropdown as required after entering cost * tests for price listener * tests for price radio listener
…n increment (#2740) * Dvorak / 2725 Character limit for the enrollment procedure description increment * deleted yarn.lock changes
* Automatic formatting of the entered date Added directives for date to all date inputs Fixed datepicker icon appearance * removed comments * fixed naming * requested changes * deleted comments
* add server error page
…utton (#2745) * Message enum for buttons added, fixed create-provider loading * tests added
* visual improvement of employee upload page * fixed typo errors * fixed typo errors * lint * requested changes
#2733) * max length validation fixed * tests added * logic moved, formatting fixed * required hint fixed * validation hint refactored * currentCharactersCount message fixed * code improvement * magic constants removed * Opportunity to add empty line added * message splitting removed * translation detection fixed, conflicts resolved * comments fix * rabbit comments fix * condition comment changed
* created dto files * deleted unused files * primary version of draft feature some changes for using workshop model created first primary version for drafts fixed test failing added action for deleting added store actions and api check for first form step fixed saving step information with API fixed draft sending & implemented loading draft from API added additional property fixed tags converting fixed step redirecting fixed address saving and displaying in draft mode fixed save button disable condition when drafting fixed missing isPaid property added modal window for notification about draft fixed tests added remaining time for auto deleting fixed unwanted delay for displaying banner hotfix added tests replaced endpoints name into new small fix added eror handling in actions made edits & renamed from draft to unfinished fix comments small fixes for state management hotfix * fixed incompatibility with new contacts * fixed test failing * add some tests * added correct button naming when draft modal is shown * updated contacts sending * fix comments * mode constant usage
…d error (#2759) * changed project domain * installed tailwind dependencies * shared components updated * shell components were updated * made changes that requested in comments * remove flex-layout imports in some files * remove flex-flayout dependency in yarn.lock * updated yarn.lock * added cleaner method before loading --------- Co-authored-by: darynkka <[email protected]>
* mat-form-field and mat-input migrated * mat-select migrated * city-filter font size changed, formatting fixed * "!important" removed where it is possible * code rabbit comment fix, unused import removed
…idations improvement (#2760) * changed project domain * installed tailwind dependencies * shared components updated * shell components were updated * made changes that requested in comments * remove flex-layout imports in some files * remove flex-flayout dependency in yarn.lock * updated yarn.lock * the structure of the sent data has been changed, a check for RNOKPP and module tests have been added * complex PR that contain #2756, #2753, #2748 issues * added unit tests * changed naming --------- Co-authored-by: darynkka <[email protected]>
* temporarily removed teachers * fixed marking form as dirty on tags change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.