Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom profiling commands & flamegraphs #890

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Custom profiling commands & flamegraphs #890

wants to merge 43 commits into from

Conversation

oschaaf
Copy link
Contributor

@oschaaf oschaaf commented Apr 15, 2020

Allows running custom profiling command on the nodes via bcc-tools
and perf, and obtains flamegraphs based on that.

See the updated README.md in perf/benchmark for examples and more
information.

Signed-off-by: Otto van der Schaaf [email protected]

@oschaaf
Custom profiling commands & flamegraphs
1d5d128 
Allows running custom profiling command on the nodes via bcc-tools
and perf, and obtains flamegraphs based on that.

See the updated README.md in perf/benchmark for examples and more
information.

Signed-off-by: Otto van der Schaaf <[email protected]>
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 15, 2020
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 15, 2020
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2020
@istio-testing
Copy link
Contributor

Hi @oschaaf. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oschaaf oschaaf mentioned this pull request Apr 15, 2020
Closed
@carolynhu
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Apr 15, 2020
@oschaaf
Docker linting, fix TODO
70b6e52 
Signed-off-by: Otto van der Schaaf <[email protected]>
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 16, 2020
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 16, 2020
@oschaaf
Docker lint tweak
81d4d7a 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Add perf label to flamegraph filename
ee62a80 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Deduplicate redundant functionality
689021b 
As --custom_profiling_command offers a superset of --perf,
reimplement the old --perf flag using that and eliminate the
redundant code.

Signed-off-by: Otto van der Schaaf <[email protected]>
@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2020
@carolynhu
Copy link
Contributor

@oschaaf you can ignore the benchmar_check_tools job failure, since there is a change made in the operator side, and we are fixing it.

@oschaaf
Merge remote-tracking branch 'upstream/master' into profiling
a3f5587 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Dockerfile.perf linting: pin package versions
bffad09 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
bash linting: double quote arg
6425935 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Add licence / copyright banner
81f4d4d 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Python whitespace linting fix
b37cea8 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Markdown linting fixes
d5d5d59 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Merge remote-tracking branch 'upstream/master' into profiling
4871583 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Move profiling thread start into function
eb6090f 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Python linting fix
6730880 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Merge remote-tracking branch 'upstream/master' into profiling
2886e04 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Sync up with the latest changes
fa42cab 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
linting fixes + fix in fortio.yaml
680b10c 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Changes ot minimize the diff
30342ff 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Merge remote-tracking branch 'upstream/master' into profiling
0b9e851 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Merge remote-tracking branch 'upstream/master' into profiling
2fccdd6
@oschaaf
Tweak flamegraph file naming
83a8e40 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Fix NH-mode --ingress option
94f6120 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Lint fix
7f28c4c 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Small enhancenments/fixes
e274665 
- Html encode title we hand to flamegraph.py
- Fix a typo in README.md
- Avoid writing to stdout/stderr from threaded code

Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Fix hang, improve error handling. Doc enhancements.
b96687e 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Merge remote-tracking branch 'upstream/master' into profiling
17d136a
@oschaaf
Lint change in runner.py
aae1f19 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Flag for allowing short runs. Doc pagefault flamgraphing.
fdfe910 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
runner.py: add --envoy_profiler option
47c63f5 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Lint fixes
b2aa8f0 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Merge remote-tracking branch 'upstream/master' into profiling
1c5a3dd
@oschaaf
Markdown lint fixes
b19423b 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf
Add scrape annotations for prom. node exporter
70e8f5a 
Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf oschaaf marked this pull request as ready for review May 13, 2020 10:48
@oschaaf oschaaf requested a review from a team May 13, 2020 10:48
@oschaaf oschaaf requested a review from a team as a code owner May 13, 2020 10:48
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 13, 2020
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 30, 2020
@istio-testing
Copy link
Contributor

@oschaaf: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Contributor

@oschaaf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
containers-test-arm64_tools 50a2a63 link true /test containers-test-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. needs-rebase Indicates a PR needs to be rebased before being merged ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@oschaaf @istio-testing @carolynhu @googlebot