Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning #50995

Merged
merged 2 commits into from May 13, 2024
Merged

Fix warning #50995

merged 2 commits into from May 13, 2024

Conversation

hzxuzhonghu
Copy link
Member

@hzxuzhonghu hzxuzhonghu commented May 11, 2024

Please provide a description of this PR:

fix #50805

@hzxuzhonghu hzxuzhonghu requested review from a team as code owners May 11, 2024 03:14
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2024
Copy link
Member

@hanxiaop hanxiaop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description link seems to be wrong, I assume it's for #50805

pkg/config/analysis/msg/messages.yaml Show resolved Hide resolved
@hzxuzhonghu hzxuzhonghu added the release-notes-none Indicates a PR that does not require release notes. label May 13, 2024
@hzxuzhonghu
Copy link
Member Author

/retest

@istio-testing istio-testing merged commit f827158 into istio:master May 13, 2024
28 checks passed
@hzxuzhonghu hzxuzhonghu deleted the fix-warning branch May 13, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants