Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy stable validation policy to istiod-remote #50923

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Copy stable validation policy to istiod-remote #50923

wants to merge 1 commit into from

Conversation

whitneygriffith
Copy link
Contributor

@whitneygriffith whitneygriffith commented May 8, 2024 •
edited by istio-policy-bot

Please provide a description of this PR:

Part of Release Channels: 173

@whitneygriffith whitneygriffith requested review from a team as code owners May 8, 2024 16:45
@istio-policy-bot istio-policy-bot added area/environments release-notes-none Indicates a PR that does not require release notes. labels May 8, 2024
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2024
@whitneygriffith whitneygriffith added the cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch label May 8, 2024
@whitneygriffith
copy stable policy to istiod-remote
20b2670 
Signed-off-by: Whitney Griffith <[email protected]>
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2024
jaellio
jaellio reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@jaellio jaellio left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there stable configuration tests for each chart type? Do we verify no non-stable resources are present for each applied chart type?

@whitneygriffith
Copy link
Contributor Author

Are there stable configuration tests for each chart type? Do we verify no non-stable resources are present for each applied chart type?

I can't easily think of a way to automatically test that the expected manifests are in each chart type. I am open to suggestions and we can create an issue to track it.

MorrisLaw
MorrisLaw approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@MorrisLaw MorrisLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@whitneygriffith
Copy link
Contributor Author

PTAL @ericvn @zirain @stevenctl

zirain
zirain requested changes May 17, 2024
View reviewed changes
Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cherry-pick, please add release-notes.

@whitneygriffith
Copy link
Contributor Author

For cherry-pick, please add release-notes.

This is a bug fix that relates to release channels. There is already a release notes for release channels. Do I still need to add another?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaellio jaellio jaellio left review comments

@zirain zirain zirain requested changes

@keithmattix keithmattix keithmattix approved these changes

@MorrisLaw MorrisLaw MorrisLaw approved these changes

@stevenctl stevenctl stevenctl approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/environments cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@whitneygriffith @keithmattix @zirain @MorrisLaw @stevenctl @jaellio @istio-testing @istio-policy-bot