sds: simplify implementation to reduce dependencies #50828
Conversation
Change-Id: Ie9e4dd8a0a404671616e2fd1b97ffbe558fa85d1 Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: I7b318d10d4809ea97693d587425bafbd22f53b6a Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: Id8d118a96f38895a6e0e334a2d9a57645e9b53d6 Signed-off-by: Kuat Yessenov <[email protected]>
istio-testing
added
the
size/L
kyessenov
added
the
release-notes-none
|
/retest |
Change-Id: Ice126f4bcbbc364c511139cf21fe5e5f4991de51 Signed-off-by: Kuat Yessenov <[email protected]>
|
I don't quite understand where |
|
The syncz is istio/pkg/istio-agent/xds_proxy.go Line 787 in 903ba1a |
Change-Id: I1341a3a0eef107f8ba4d3c500bf43163a989833c
Change-Id: Ia02658149db8f3f5d663774de75733cb067a7250 Signed-off-by: Kuat Yessenov <[email protected]>
|
@howardjohn OK, that will pull all the Envoy protos used in listener, cluster, route, and extensions -- something we don't want to do just for debug endpoint. I removed that test since it doesn't seem to be critical -- you can decode Protos out of band. |
Change-Id: Iee6a5007352cc433ab572c9c18bb79e0f5e38f30
|
@syw14 I think this change is fine because |
istio-testing
added
the
needs-rebase
| @@ -33,6 +33,7 @@ import ( | |||
| "istio.io/istio/pkg/test/util/assert" | |||
| "istio.io/istio/pkg/util/sets" | |||
| "istio.io/istio/pkg/workloadapi" | |||
| xdsserver "istio.io/istio/pkg/xds" | |||
There was a problem hiding this comment.
| xdsserver "istio.io/istio/pkg/xds" | |
| "istio.io/istio/pkg/xds" |
There was a problem hiding this comment.
Package name conflict.
| @@ -41,6 +41,7 @@ import ( | |||
| "istio.io/istio/pkg/spiffe" | |||
| "istio.io/istio/pkg/test/env" | |||
| "istio.io/istio/pkg/util/sets" | |||
| xdsserver "istio.io/istio/pkg/xds" | |||
There was a problem hiding this comment.
Same, with pilot/test/xds.
| resources := model.Resources{} | ||
| var version uberatomic.Uint64 | ||
|
|
||
| func (s *sdsservice) generate(resourceNames []string) (*discovery.DiscoveryResponse, error) { |
There was a problem hiding this comment.
feel a little duplicate if we write a bunch of methods again
There was a problem hiding this comment.
You mean the version? Yes, but it's just two lines. It would be more code if we share.
Change-Id: Ie383aa56c5d8d0e6c8553faa5d6335b3e94e4199 Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: I084740c88ed006f593384d4f8eb0cf42a3200274 Signed-off-by: Kuat Yessenov <[email protected]>
istio-testing
removed
the
needs-rebase
Issue: #50134
This brings down the binary size for pilot-agent to under 30MB.
CC @dpasiukevich