pilot: fix bug in endpoint updates #50746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
|
Skipping CI for Draft Pull Request. |
istio-testing
added
do-not-merge/work-in-progress
|
/test all |
howardjohn
force-pushed
the
pilot/endpoint-update
branch
from
ef975e3
to
1ee0d93
Compare
|
/test all |
|
@hzxuzhonghu @ramaraochavali wdyt? if desired ill write an optimized Equals function |
|
Yes. I agree we should compare. I think all of this used to be in |
TBH I am not sure how this isn't a bigger issue. Currently if an endpoint changes we are not triggering a push at all. In this case, it was port number, but could be others. Implementation is *bad* right now, but if this is desired we can swap for an optimized Equals implementation
howardjohn
force-pushed
the
pilot/endpoint-update
branch
from
1ee0d93
to
0a24f5c
Compare
istio-testing
added
size/L
howardjohn
commented
May 13, 2024
Comment on lines
+245
to
+251
| // Endpoint update is triggered since its a brand new service | ||
| if ev := fx.WaitOrFail(t, "xds full"); !ev.Reason.Has(model.EndpointUpdate) { | ||
| t.Fatalf("xds push reason does not contain %v: %v", model.EndpointUpdate, ev) | ||
| } | ||
| // headless service update must trigger nds push, so we trigger a full push. | ||
| ev := fx.WaitOrFail(t, "xds full") | ||
| if !ev.Reason.Has(model.HeadlessEndpointUpdate) { | ||
| t.Fatalf("xds push reason does not contain %v", model.HeadlessEndpointUpdate) | ||
| if ev := fx.WaitOrFail(t, "xds full"); !ev.Reason.Has(model.HeadlessEndpointUpdate) { | ||
| t.Fatalf("xds push reason does not contain %v: %v", model.HeadlessEndpointUpdate, ev) |
There was a problem hiding this comment.
This is NOT a production impact change. Only test.
Now our test properly mimics how the real istiod does pushes; in the real world we are triggering double pushes.
Note with debounce its mostly moot, though
howardjohn
added
cherrypick/release-1.21
istio-testing
removed
the
do-not-merge/work-in-progress
howardjohn
force-pushed
the
pilot/endpoint-update
branch
from
0a24f5c
to
371ce1f
Compare
ramaraochavali
approved these changes
May 14, 2024
|
In response to a cherrypick label: new pull request created: #51025 |
|
In response to a cherrypick label: #50746 failed to apply on top of branch "release-1.21": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #51026 |
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
May 14, 2024
* pilot: fix bug in endpoint updates TBH I am not sure how this isn't a bigger issue. Currently if an endpoint changes we are not triggering a push at all. In this case, it was port number, but could be others. Implementation is *bad* right now, but if this is desired we can swap for an optimized Equals implementation * Prod impl (cherry picked from commit 53a49fe)
istio-testing
pushed a commit
that referenced
this pull request
May 15, 2024
* pilot: fix bug in endpoint updates TBH I am not sure how this isn't a bigger issue. Currently if an endpoint changes we are not triggering a push at all. In this case, it was port number, but could be others. Implementation is *bad* right now, but if this is desired we can swap for an optimized Equals implementation * Prod impl (cherry picked from commit 53a49fe)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBH I am not sure how this isn't a bigger issue. Currently if an
endpoint changes we are not triggering a push at all. In this case, it
was port number, but could be others.
Implementation is bad right now, but if this is desired we can swap
for an optimized Equals implementation