Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the trusted CA from the OIDC config to the HTTP GET call just like POST #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asa-yeamans
Copy link

The GET call does not provide the trusted CA cert in opt to the HTTP GET call. Setting ca_cert to the provided value in the OIDC config

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asa-yeamans
Once this PR has been reviewed and has the lgtm label, please assign brenodemedeiros for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dio
Copy link
Collaborator

dio commented May 4, 2023

Could you fix DCO? I think this is a legit change. Thanks!

@asa-yeamans
Copy link
Author

Added DCO bits

…a its config like with OidcFilter

Signed-off-by: Asa Yeamans <[email protected]>
@jbraswell
Copy link

Any updates here? We'd love to have this fix.

@asa-yeamans
Copy link
Author

I am unable to build it locally due to issues creating a build environment, so I haven't been able to verify the changes build and subsequently that they perform as expected. The changes themselves are minimal so I presume they work, but assistance in verifying that would be helpful.

@nacx
Copy link
Collaborator

nacx commented Mar 26, 2024

This should have been addressed in v1.0.0 already, as part of the Go rewrite. Could you give it a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants