-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat:stash] add stash API for push, apply, pop, drop, list and clean #228 #980 #1878 #1898
base: main
Are you sure you want to change the base?
Conversation
… drop, list and clear, plus 18 test cases
…somorphic-git#980, also add more test cases for changes and deletion under a folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looks good, but there are few things:
- Can you test untracked files if they stay intact?
- Do you plan to add ref to stash commands? This is part of canonical git where you can pop or apply different stash entry based on ref (e.g.:
stash@{21}
) we can use index of entry.
Next commit will add three more test cases:
yep, it can be added |
… correct the codespell error, plus other tweaks
new commit b9aec41 has added ref (the ref index of stash) to apply, pop and drop, also added more tests on untracked files, valid/invalid refIdx, default stash message, etc., total test cases are 34. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only a few minor things in tests that you can simplify
I've added comments to the commit, they are not visible on the PR. |
there are some conflicts. I'm marking as ready to reference it back. |
I'm adding a new command: stash
src/api
(andsrc/commands
if necessary)src/index.js
__tests__/test-exports.js
src/__tests__
- test-stash covers 22 test caseswebsite/sidebars.json
website/versioned_sidebars/version-1.x-sidebars.json
npm run add-contributor
and follow the prompts to add yourself to the README