Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Buffer dependency #1745

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

jonathantneal
Copy link

@jonathantneal jonathantneal commented Mar 15, 2023

This pull requests continues where #925 leaves off.

Changes from that PR:

  • Checkout existing PR and rebase with current main branch.
  • Remove unused arraybuffer-equal dependency from prior PR.
  • Minor tweaks to following formatting conventions in current project.
  • Run npm run add-contributor and follow the prompts to add yourself to the README

Notes:

  • I am open to corrections and changes. I have only somewhat familiarized myself with the project.
  • I was unable to run the tests successfully from the main branch, making it difficult to debug this feature branch.
  • I had difficulty using nps, namely isolating individual scripts for debugging. I found commands to run via npx.
  • In order to build the project locally, I needed to use NODE_OPTIONS=--openssl-legacy-provider.
    # example
    NODE_OPTIONS=--openssl-legacy-provider npx webpack --config webpack.config.cjs

@jonathantneal jonathantneal changed the title Eliminate Buffer dependency [WIP] Eliminate Buffer dependency Mar 15, 2023
@jonathantneal jonathantneal marked this pull request as ready for review March 15, 2023 14:47
@jcubic
Copy link
Contributor

jcubic commented Mar 17, 2023

You will need to fix the broken unit tests.

There is an error: "Failed to tree-shake index.js":

https://dev.azure.com/isomorphic-git/isomorphic-git/_build/results?buildId=3040&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=5b4cc83a-7bb0-5664-5bb1-588f7e4dc05b

I'm not sure why

@jcubic
Copy link
Contributor

jcubic commented Feb 15, 2024

Please update with main since there was fixes to unit tests. Also you will need to resolve conflicts. I'm not sure if you will be able to do rebase if there are conflicts.

You can try to remove yourself from README.md and .all-contributorsrc rebase and add yourself again. You can run interactive rebase and remove the commit where you added yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants