Skip to content

シェア機能を作りました #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 23, 2023
Merged

シェア機能を作りました #94

merged 7 commits into from
Aug 23, 2023

Conversation

iseruuuuu
Copy link
Owner

@iseruuuuu iseruuuuu commented Aug 21, 2023

@iseruuuuu iseruuuuu self-assigned this Aug 21, 2023
@iseruuuuu iseruuuuu added the enhancement New feature or request label Aug 21, 2023
@iseruuuuu
Copy link
Owner Author

iseruuuuu commented Aug 21, 2023

やること

  • Twitterのシェア機能がしっかりとできているか確認する
  • Lineのシェア機能がしっかりとできているかを確認する。
  • Instagramのシェア機能がしっかりとできているか確認する
    →適宜設定が必要そう。

@iseruuuuu iseruuuuu added this to the リリース前 milestone Aug 22, 2023
@iseruuuuu
Copy link
Owner Author

明日レビュー予定です👌

Comment on lines +35 to +40
<key>LSApplicationQueriesSchemes</key>
<array>
<string>items</string>
<string>twitter</string>
<string>instagram</string>
</array>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この文言を追加すると、TwitterとInstagramに飛べるっぽい。

https://qiita.com/Riscait/items/422cc22873371617c850

Copy link
Owner Author

@iseruuuuu iseruuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iseruuuuu iseruuuuu merged commit 2bbad8c into main Aug 23, 2023
@iseruuuuu iseruuuuu deleted the feature/share branch August 23, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment