fix: Remove mutable OJS syntax causing runtime errors #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mutable dbState` declaration was causing "mutable dbState is not
defined" errors in the browser. This was due to OJS/Quarto syntax issues
with the mutable keyword.
Simplified the approach:
- Removed mutable state tracking entirely
- initDatabases now returns { narrow, wide } on success or { error } on failure
- dbNarrow/dbWide derived from initDatabases with proper null checks
This follows the simpler pattern used in parquet_cesium.qmd.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "mutable dbState is not defined" runtime errors on the narrow_vs_wide_performance.html page.
Problem
The
mutable dbStatedeclaration was causing JavaScript runtime errors in the browser. The OJS/Quarto mutable syntax was not being processed correctly, resulting in the page failing to load any benchmarks.Solution
initDatabasesnow returns{ narrow, wide }on success or{ error }on failuredbNarrow/dbWidederived frominitDatabaseswith proper null checksThis follows the simpler pattern used in
parquet_cesium.qmdwhich works correctly.🤖 Generated with Claude Code