-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L10n fr #17
L10n fr #17
Conversation
Wow, huge work here! 😮 Probably it needs to be reviewed by other French-speaking people. Can you ping someone? |
Sure. Pinging @gorhgorh and @JeremiePat, they're used to it 😄 |
de caractères et `yield` chacune en majuscule, à tour de rôle. | ||
|
||
**Le souci :** quelqu’un a envoyé un nombre au lieu d’une chaîne et `upper()` | ||
est cassée. Merci de la réparer. Si `upper()` se prend un nombre, elle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"se prend" -> "reçoit"
|
||
## Défi | ||
|
||
Écrivez une fonction générateur `factorial(n)` qui calculera la factorielle de chaque nombre entier de 1 jusqu’à `n`. Chaque itération successive renverra (avec `yield`) la factorielle suivante, jusqu’à arriver au bout de la séquence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hé @JeremiePat tu en penses quoi sous cette forme ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ben ouais, c'est carrément plus claire. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"clair", même 😜 On fait ça.
Hey @isRuslan we're all green on the FR version now, you're clear to merge! (I'd appreciate if you could notify me through e-mail once you've bumped on npm, too). Cheers! |
Booom! Bumped as I added you both as collaborators to this project to keep French translations fresh. |
Hey Ruslan, Thanks for the vote of confidence! Actually the See https://github.com/rvagg/learnyounode/tree/master/i18n/help for an example (many other workshops follow suit). You could then just link to the Best, |
Hey Ruslan!
First, thanks for the workshop, it's pretty cool 😄
As part of the g11n effort in nodeschool/organizers#64, I updated the deps to the latest workshopper infrastructure, expanded g11n to include credits and an untranslated error message, and added FR.
I hope you'll find this to your liking. I remain open to any discussion, obviously.
If you're happy with it, I'm looking forward to this PR being merged and an updated version coming up on npm.
Best,