Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L10n fr #17

Merged
merged 5 commits into from
Feb 26, 2015
Merged

L10n fr #17

merged 5 commits into from
Feb 26, 2015

Conversation

tdd
Copy link
Collaborator

@tdd tdd commented Feb 26, 2015

Hey Ruslan!

First, thanks for the workshop, it's pretty cool 😄

As part of the g11n effort in nodeschool/organizers#64, I updated the deps to the latest workshopper infrastructure, expanded g11n to include credits and an untranslated error message, and added FR.

I hope you'll find this to your liking. I remain open to any discussion, obviously.

If you're happy with it, I'm looking forward to this PR being merged and an updated version coming up on npm.

Best,

@isRuslan
Copy link
Owner

Wow, huge work here! 😮
Technically, looks good to me. I'd love to split credits in that way. And put errors to config.

Probably it needs to be reviewed by other French-speaking people. Can you ping someone?

@tdd
Copy link
Collaborator Author

tdd commented Feb 26, 2015

Sure. Pinging @gorhgorh and @JeremiePat, they're used to it 😄

de caractères et `yield` chacune en majuscule, à tour de rôle.

**Le souci :** quelqu’un a envoyé un nombre au lieu d’une chaîne et `upper()`
est cassée. Merci de la réparer. Si `upper()` se prend un nombre, elle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"se prend" -> "reçoit"


## Défi

Écrivez une fonction générateur `factorial(n)` qui calculera la factorielle de chaque nombre entier de 1 jusqu’à `n`. Chaque itération successive renverra (avec `yield`) la factorielle suivante, jusqu’à arriver au bout de la séquence.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeremiePat tu en penses quoi sous cette forme ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ben ouais, c'est carrément plus claire. 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"clair", même 😜 On fait ça.

@tdd
Copy link
Collaborator Author

tdd commented Feb 26, 2015

Hey @isRuslan we're all green on the FR version now, you're clear to merge!

(I'd appreciate if you could notify me through e-mail once you've bumped on npm, too).

Cheers!

isRuslan added a commit that referenced this pull request Feb 26, 2015
@isRuslan isRuslan merged commit ed7c64b into isRuslan:master Feb 26, 2015
@isRuslan
Copy link
Owner

Booom! Bumped as 1.3.0.
Thank you guys @tdd @JeremiePat for a great work!

I added you both as collaborators to this project to keep French translations fresh.
Also, I added some instructions in README to help to understand learning flow.
I guess it will be helpful to create README.fr.md with full translation of main README (screenshot, instructions and etc) and link this as menu at the top. What do you think?

@tdd
Copy link
Collaborator Author

tdd commented Feb 26, 2015

Hey Ruslan,

Thanks for the vote of confidence!

Actually the workshopper way of doing this would be through localized files in i18n/help/<lang>.txt. These are read and merged on top of the default display for the menu's builtin HELP item.

See https://github.com/rvagg/learnyounode/tree/master/i18n/help for an example (many other workshops follow suit).

You could then just link to the i18n/help/en.txt blob from the README, for instance, to keep things dry.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants