fix(types): Handle 12-hour time formats and narrow non-breaking spaces

[irvinlim]

Fixes #25.

[tedpearson]

Just a few minor comments, but seems good overall.

BTW, It irks me a little how inefficient the try-each-format parsing is, but while that could be improved, it's not necessary to over-engineer a solution for code that doesn't run very often. 🙂

[irvinlim]

BTW, It irks me a little how inefficient the try-each-format parsing is, but while that could be improved, it's not necessary to over-engineer a solution for code that doesn't run very often. 🙂

I've added a lastUsedTimeFormat global variable that caches the last-known good time format that was used, to address this concern. I think this should be suitable for most use cases, since we likely can easily speed up time parsing of many timestamps in a single JSON blob by short-circuiting to the correct time format, and it's also highly unlikely that users would use different iOS region settings that sync to the same ingester server. 🙂

On top of that, I also think we should support both AM/PM and am/pm time formats. Go's time.Parse differentiates between the two 😮‍💨 But with the caching of the lastUsedTimeFormat I think the cost of adding new formats should be largely mitigated!

For your review again!

[tedpearson]

I've added a lastUsedTimeFormat global variable that caches the last-known good time format that was used, to address this concern. I think this should be suitable for most use cases, since we likely can easily speed up time parsing of many timestamps in a single JSON blob by short-circuiting to the correct time format, and it's also highly unlikely that users would use different iOS region settings that sync to the same ingester server. 🙂

Yeah this is a decent improvement. 🙂

On top of that, I also think we should support both AM/PM and am/pm time formats. Go's time.Parse differentiates between the two 😮‍💨 But with the caching of the lastUsedTimeFormat I think the cost of adding new formats should be largely mitigated!

Works for me! This PR looks good now.