Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Fedora-40: Use explicit pointer casts in some more places #396

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

olebole
Copy link
Member

@olebole olebole commented Apr 15, 2024

The first argument in ZOPNND() should really be declared as a char *. However it is a SPP called function and therefore limited to the SPP data types; so the first argument is declared as PKG_CHAR * (which is a short int). Therefore we need to cast it when called from C.

Another point is the wrong pointer type in zfioks.c, which is resolved here as well.

Fixes: #395

The first argument in ZOPNND() should really be declared as a `char *`.
However it is a SPP called function and therefore limited to the SPP
data types; so the first argument is declared as `PKG_CHAR *` (which
is a `short int`). Therefore we need to cast it when called from C.
@olebole olebole changed the title Use explicit pointer cast for zopnnd call in zfiobf.c Fix build on Fedora-40: Use explicit pointer cast for zopnnd call in zfiobf.c and others Apr 21, 2024
@olebole olebole changed the title Fix build on Fedora-40: Use explicit pointer cast for zopnnd call in zfiobf.c and others Fix build on Fedora-40: Use explicit pointer casts in some more places Apr 21, 2024
@olebole olebole merged commit d85a9ed into iraf-community:main Apr 23, 2024
4 checks passed
@olebole olebole deleted the fix_zopnnd_call branch April 25, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Errors when building on Fedora 40
1 participant