NOIRLAB: Re-add the vtel package #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 81a39f4, except that the NR code is not re-added, and the test file test/files.md is adjusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vtel package was removed in the process of the removal of the non-free code from Numerical Recipes (iraf-v216#37).
The Noirlab fork however had the better way, removing only the affected rmap task. This PR updates to their solution, and adds a small bugfix there. For reference, the used commits:
5133124 - fix type error using imaddr
d7c92ef - remove RMAP task defs, fixes noirlab-iraf/iraf-v218#12
c5074d5 - remove RMAP task to eliminate NR code, fixes noirlab-iraf/iraf-v218#12