Clean up some of the management key code #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
330-mgm-cleanups
branch
from
32a3164 to
5e99c58
Compare
str4d
force-pushed
the
330-mgm-cleanups
branch
from
5e99c58 to
654cc41
Compare
|
Rebased on |
This was referenced Jan 4, 2025
| /// Size of a 3DES key | ||
| pub(crate) const DES_LEN_3DES: usize = DES_LEN_DES * 3; | ||
|
|
||
| /// Weak and semi weak DES keys as taken from: |
There was a problem hiding this comment.
@baloo will we be able to replace these checks using the weak key feature in next (pre)release of the des crate?
tony-iqlusion
approved these changes
Feb 11, 2025
|
Thanks! Sorry for the long review cycle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #330.