Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash/reboot loop on Mac mini 2018 #1130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/interface/efi/efi_veto.c
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,38 @@ efi_veto_vmware_uefipxebc ( EFI_DRIVER_BINDING_PROTOCOL *binding __unused,
return 1;
}

/**
* Veto Apple Inc. Mac Mini 2018 T2 wifi driver crash on cold boot
*
* @v binding Driver binding protocol
* @v loaded Loaded image protocol
* @v wtf Component name protocol, if present
* @v manufacturer Manufacturer name, if present
* @v name Driver name, if present
* @ret vetoed Driver is to be vetoed
*/
static int
efi_veto_apple_mac_mini_2018_t2 ( EFI_DRIVER_BINDING_PROTOCOL *binding __unused,
EFI_LOADED_IMAGE_PROTOCOL *loaded __unused,
EFI_COMPONENT_NAME_PROTOCOL *wtf __unused,
const char *manufacturer, const CHAR16 *name ) {
static const CHAR16 uefipxebc[] = L"Broadcom 802.11 Dongle Host Driver";
static const char *broadcom = "Apple Inc.";

/* Check manufacturer and driver name */
if ( ! manufacturer )
return 0;
if ( ! name )
return 0;
if ( strcmp ( manufacturer, broadcom ) != 0 )
return 0;
if ( memcmp ( name, uefipxebc, sizeof ( uefipxebc ) ) != 0 )
return 0;

return 1;
}


/** Driver vetoes */
static struct efi_veto_candidate efi_vetoes[] = {
{
Expand All @@ -508,6 +540,10 @@ static struct efi_veto_candidate efi_vetoes[] = {
.name = "VMware UefiPxeBc",
.veto = efi_veto_vmware_uefipxebc,
},
{
.name = "Apple Inc Mac Mini 2018 T2 Cold boot",
.veto = efi_veto_apple_mac_mini_2018_t2,
},
};

/**
Expand Down