Improve logging by writing to module-level loggers instead of the root logger #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the setup recommended in the Logging How-To here: https://docs.python.org/3/howto/logging.html#library-config. This should give users much more flexibility with how they filter and handle log messages from hlink. And it makes the logging %(name)s attribute meaningful for hlink as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149.
Previously we used the convenience functions on the
loggingmodule to log all of hlink's messages. But this sends all of the log messages directly to the root logger. This makes it difficult to adjust the logging level and handling specifically for hlink log messages without affecting those of other modules'.Now we create a logger for each module, which means that each log message goes through the
hlinklogger before it goes to the root logger. This also gives more information about which module each log message comes from. You can now adjust the logging level just for hlink by