Refactor core.transforms.generate_transforms() for ease of reading #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it no longer captures variables from the generate_transforms() function, so we should be ready to move it up to the module level.
I've made this private since it's intended for module use only.
…elections() Pass arguments into the function instead of capturing them from the environment.
ccdavis
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Makes sense to me. If the helper functions rely on state from the enclosing scope or it's not clear if they can be victims of side-effects or cause side-effects, they need to be improved. Making them into pure (or more pure) private functions makes is a good move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141.
This PR refactors the
core.transforms.generate_transforms()function by pulling out several functions defined within this larger function. The previous format with nested functions was difficult to read becausegenerate_transforms()was several hundred lines long and because some of the nested functions closed over variables ingenerate_transforms(). After the refactor, some of the functions are still pretty long, but the module is much more navigable than before.I've pulled the nested functions out as private functions in the
core.transformsmodule. The public API of this module should not change at all with this change, and there shouldn't be any functionality changes either.During the refactor, I also discovered the
skipattribute which is available to all feature selection transforms. I added some tests for it and added it to the documentation.