Support a variable number of columns in the array feature selection transform #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #134.
Previously, the
array
feature selection transform defined in hlink/linking/core/transforms.py required exactly two input columns. This change updates the transform to accept any number of columns instead. This is a small change because thepyspark.sql.functions.array()
function already accepts a variable number of input columns to pack into the output column.I also took this opportunity to add a few tests specifically for this feature and add type hints to the
generate_transforms()
function.