Fix a bug with the override_column_X attributes in conf_validations.py #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130.
In issue #118 we documented the override_column_a and override_column_b attributes for column mappings and added some tests for those. I forgot to check the config validation though, and there was no logic in there for handling the override_column_X attributes. So if you used the override_column_X attributes in a column mapping, you'd still get a config validation error from the conf_validations module. If you decided to run hlink anyways, it probably ran without errors. The bug was just in the analysis code, not in the core module code.
I've added some more unit tests for this section of the code and refactored the
check_column_mappings()
function to make it easier to work with.The changes to hlink/linking/matching/link_step_explode.py are
black
formatting changes.black
has updated since we last made a change to hlink.