Skip to content

Commit

Permalink
[#21] Rename two tests that referenced the wrong matching step
Browse files Browse the repository at this point in the history
  • Loading branch information
riley-harper committed Jun 18, 2024
1 parent d273ec3 commit b87ed91
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions hlink/tests/matching_scoring_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,8 @@ def test_step_3_uniq_and_secondary_threshold(spark, matching_conf, matching):
assert unique_high_matches_df.empty


# TODO: is there a step 3 anymore?
def test_step_3_skip_on_no_conf(spark, matching_conf, matching, capsys):
"""Test matching step 3 doesn't run if no training config"""
def test_step_2_skip_on_no_conf(spark, matching_conf, matching, capsys):
"""Test matching step 2 doesn't run if no training config"""

matching_conf["comparison_features"] = [
{
Expand All @@ -102,11 +101,10 @@ def test_step_3_skip_on_no_conf(spark, matching_conf, matching, capsys):
)


# TODO: is there a step 3 any more?
def test_step_3_alpha_beta_thresholds(
def test_step_2_alpha_beta_thresholds(
spark, matching, matching_conf, threshold_ratio_data_path_2
):
"""Test matching step 3 with both probability and ratio thresholds"""
"""Test matching step 2 with both probability and ratio thresholds"""

matching.spark.read.csv(
threshold_ratio_data_path_2, header=True, inferSchema=True
Expand Down

0 comments on commit b87ed91

Please sign in to comment.