Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix missing html5lib dependency #348 #349

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

vss-2
Copy link
Contributor

@vss-2 vss-2 commented Apr 23, 2024

Adds html5lib to Poetry's dependencies in order to fix python package testing pipeline.

@vss-2
Copy link
Contributor Author

vss-2 commented Apr 23, 2024

Sorry for the excessive commits.
The thing is: besides the missing package, the current Python implementation of list_geobr(), which goes to Github README.md and downloads the whole HTML then crops the table containing the dataset is no more valid.
It seems the codification have changed or it's something related to front-end (React table building lib mixing unicode characters) changes that makes previous code unable to identify where the table is (that's why the last commit has an emoji 👉 inside the code).
I've achieved a way to adapt by identifying the table using regular expressions maintaining the expected behavior.

Copy link
Contributor Author

@vss-2 vss-2 Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore changes in this specific file!

@rafapereirabr
Copy link
Member

thanks, @vss-2 !!

@rafapereirabr rafapereirabr merged commit 6e87524 into ipeaGIT:master Apr 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants