New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTO conversions as type methods instead of free functions #1516

Merged

thibault-martinez merged 2 commits into iotaledger:shimmer-develop from thibault-martinez:simplify-dto-conversions

Sep 16, 2022

Member

thibault-martinez commented Sep 16, 2022

Change checklist

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes
I have updated the CHANGELOG.md, if my changes are significant enough

thibault-martinez added 2 commits

September 16, 2022 11:03


          DTO conversions as type methods instead of free functions

90348fe


          Changelog

99a720a

thibault-martinez requested review from Thoralf-M and samuel-rufi as code owners

September 16, 2022 09:06

Thoralf-M approved these changes

View reviewed changes

samuel-rufi approved these changes

View reviewed changes

thibault-martinez merged commit b6f0812 into iotaledger:shimmer-develop

thibault-martinez deleted the simplify-dto-conversions branch

September 16, 2022 09:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet