Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TryFrom<&NftOutputDto> for NftOutput { #1259

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Fix TryFrom<&NftOutputDto> for NftOutput { #1259

merged 1 commit into from
Mar 22, 2022

Conversation

Thoralf-M
Copy link
Member

Description of change

Fix TryFrom<&NftOutputDto> for NftOutput {

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the CHANGELOG.md, if my changes are significant enough

@Thoralf-M Thoralf-M added wg-api Working Group - API n-shimmer Network - Shimmer labels Mar 22, 2022
@thibault-martinez thibault-martinez added c-bug Category - Bug e-medium Experience - Medium p-high Priority - High labels Mar 22, 2022
@thibault-martinez thibault-martinez merged commit d307ed3 into iotaledger:shimmer-develop Mar 22, 2022
@Thoralf-M Thoralf-M deleted the fix/TryFrom-NftOutputDto branch March 22, 2022 10:38
@thibault-martinez thibault-martinez added this to the v1.0 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@grtlr grtlr grtlr approved these changes

@bingyanglin bingyanglin bingyanglin approved these changes

@samuel-rufi samuel-rufi Awaiting requested review from samuel-rufi

Assignees
No one assigned
Labels
c-bug Category - Bug e-medium Experience - Medium n-shimmer Network - Shimmer p-high Priority - High wg-api Working Group - API
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Thoralf-M @thibault-martinez @grtlr @bingyanglin