feat(ci): remove need to compile scripts #5370
Open
+527
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR built and packed!Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9120837284/artifacts/1511481409 If your browser saves files to |
christian-bromann
force-pushed
the
cb/remove-scripts-build
branch
from
5587815
to
163dc0c
Compare
This is due to the fact that we are running the workflow from |
|
@tanner-reits @alicewriteswrongs this is ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently a developer working on Stencil needs to compile the entire scripts folder first before running the files in them. This seems cumbersome and there is an opportunity to improve the DX here.
What is the new behavior?
By adding
tsxwe can get rid of the intermediate build step by running TS files on demand. This simplifies a lot of internal scripts and confusion when it comes to resolving paths.Documentation
Does this introduce a breaking change?
Testing
Checkout the branch and run
npm run build.Other information
n/a