test(datetime, tab-button): update screenshots after playwright update #29502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
changed the title
There was a problem hiding this comment.
How was only one screenshot updated here?
There was a problem hiding this comment.
Apparently, the other browsers already had the one letter shortened weekdays. Chrome was the only one that still showed the 3-4 character version.
brandyscarney
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Renovate has updated Playwright to v1.44.0. The update is now using Chromium 125.0.6422.14, which leads to a different behavior with the datetime scale test. As for tab-button, it seems that there's a small rendering issue. Since it's only a few pixels in difference then it's okay to update the screenshots.
What is the new behavior?
Does this introduce a breaking change?
Other information
N/A