fix(input): add focus ring to the clear input button for ionic theme #29409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
commented
Apr 26, 2024
| @@ -214,7 +212,7 @@ configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ title, config } | |||
| await expect(clearButton).toBeVisible(); | |||
|
|
|||
| // ensure blurring native input doesn't immediately hide clear button | |||
| await page.keyboard.press('Tab'); | |||
| await pageUtils.pressKeys('Tab'); | |||
There was a problem hiding this comment.
Made this change to be consistent and to use the Tab logic for all OSs.
brandyscarney
changed the title
| const clearButton = input.locator('.input-clear-icon'); | ||
| clearButton.evaluate((el: HTMLElement) => el.classList.add('ion-focused')); | ||
| await page.waitForChanges(); | ||
| await pageUtils.pressKeys('Tab'); | ||
|
|
||
| const container = page.locator('#container'); | ||
| await expect(container).toHaveScreenshot(screenshot(`input-clear-button-focused`)); |
There was a problem hiding this comment.
How are these screenshots not updated by this PR? https://github.com/ionic-team/ionic-framework/blob/ROU-4848/core/src/components/input/test/basic/input.e2e.ts-snapshots/input-clear-button-focused-ionic-md-ltr-light-Mobile-Chrome-linux.png
There was a problem hiding this comment.
The screenshots were not updated because no visual changes happened. The focus ring is still the same shape, size, color, etc.
brandyscarney
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
When a user tabs into the clear icon button within
ion-input, it does not display a focus ring. This was displaying prior but this PR caused it to stop displaying without realizing it.What is the new behavior?
Does this introduce a breaking change?
Other information
This is for the
ionictheme.