fix(input): match medium size for ionic theme #29403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
commented
Apr 25, 2024
There was a problem hiding this comment.
These look plain because underlined hasn't been implemented yet.
sean-perkins
approved these changes
Apr 30, 2024
|
Sean approved this, so going to remove myself from review. Let me know if you'd still like me to take a look though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
There is only one size, large, for
ionictheme. Developers can also leave it undefined and no styles will be applied.What is the new behavior?
mediumsize has been added. It's also being used as the default.Does this introduce a breaking change?
Other information
Verify that interactive elements can be accessed in the start and end slots along with the clear icon button.
Preview