feat(card): set round as the default shape for all themes #29387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
changed the title
sean-perkins
approved these changes
Apr 24, 2024
brandyscarney
commented
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
shapeproperty defaults toundefinedwhich evaluates to the "Soft" shape for all themes.ionic)ios)md)undefined4px8px4px"round"16px"rectangular"0pxWhat is the new behavior?
ionic)ios)md)"soft"4px8px4px"round"16px14px12px"rectangular"0px0px0px"soft"shape using the existing values forundefinedshapeproperty to"round"for all themes and updates theborder-radiusto apply to the shape classes instead of:host"round"and"rectangular"shapes iniosandmdiostheme to use14pxfor"round"as this is taken from the card in the iOS App Storemdtheme to use12pxfor"round"as this is taken from the Material Design 3 guidelinesDoes this introduce a breaking change?
BREAKING CHANGE:
The
border-radiusof theiosandmdcard now defaults to14pxand12pxinstead of8pxand4px, respectively, in accordance with the iOS and Material Design 3 guidelines. To revert to the previous appearance, set theshapeto"soft", or override the--border-radiusCSS variable to specify a different value.